somandal commented on code in PR #16649:
URL: https://github.com/apache/pinot/pull/16649#discussion_r2291490911
##########
pinot-common/src/main/java/org/apache/pinot/common/audit/AuditConfigManager.java:
##########
@@ -32,12 +40,10 @@
* Self-registers with the provided cluster config provider.
*/
@Singleton
-public final class AuditConfigManager {
-
+public final class AuditConfigManager implements ClusterConfigChangeListener {
Review Comment:
Can we follow the same pattern as in the server side?
`DefaultClusterConfigChangeHandler` extends `ClusterConfigChangeListener` and
is a generic framework that can be reused for other configs as well. Then have
the Audit code register with that and get the config updates
There wasn't a need to add this for controller side yet, so had left it out
at the time. But better to utilize a similar pattern IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
