tarun11Mavani commented on PR #16344: URL: https://github.com/apache/pinot/pull/16344#issuecomment-3200617979
> Looks like this feature only compacts the segment to be committed and doesn't touch the existing ones. So worst case if this leads to many small segments, we'd still need the minion task to merge them up. @klsince that's correct. During my testing I have seen that the size based segment flush calculator is not working as expected and we commit segment at a much higher pace (2x or 3x) as compared to same table clone but without this feature. I have created an issue to fix this in a follow up PR. Issue: #16632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
