dinoocch commented on code in PR #16564:
URL: https://github.com/apache/pinot/pull/16564#discussion_r2274887663
##########
pinot-common/src/main/resources/GeoLite2-ASN.mmdb:
##########
Review Comment:
Same question here -- can we really check in geolite db's? Should we?
##########
pinot-common/pom.xml:
##########
@@ -270,6 +286,11 @@
<groupId>com.google.auto.service</groupId>
<artifactId>auto-service-annotations</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.maxmind.geoip2</groupId>
+ <artifactId>geoip2</artifactId>
+ <version>4.0.1</version>
Review Comment:
I was vaguely under the impression that maxmind needed a license for
commercial use of their geo ip dbs, is that not true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
