This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 0163ddf715e broker: register LifecycleServiceStatusCallback before
Helix matchers to fail fast when broker is marked down; avoid blocking on heavy
IdealState/ExternalView convergence (#16590)
0163ddf715e is described below
commit 0163ddf715edcda57a1b198080bf00180dc18843
Author: Xiang Fu <[email protected]>
AuthorDate: Wed Aug 13 15:14:51 2025 -0700
broker: register LifecycleServiceStatusCallback before Helix matchers to
fail fast when broker is marked down; avoid blocking on heavy
IdealState/ExternalView convergence (#16590)
---
.../apache/pinot/broker/broker/helix/BaseBrokerStarter.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
index 20646204f86..67d366959d3 100644
---
a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
+++
b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
@@ -19,7 +19,6 @@
package org.apache.pinot.broker.broker.helix;
import com.google.common.base.Preconditions;
-import com.google.common.collect.ImmutableList;
import java.io.IOException;
import java.net.InetAddress;
import java.util.ArrayList;
@@ -572,7 +571,7 @@ public abstract class BaseBrokerStarter implements
ServiceStartable {
if (StringUtils.isNotEmpty(instanceTagsConfig)) {
for (String instanceTag : StringUtils.split(instanceTagsConfig, ',')) {
Preconditions.checkArgument(TagNameUtils.isBrokerTag(instanceTag),
"Illegal broker instance tag: %s",
- instanceTag);
+ instanceTag);
instanceConfig.addTag(instanceTag);
}
shouldUpdateBrokerResource = true;
@@ -622,11 +621,12 @@ public abstract class BaseBrokerStarter implements
ServiceStartable {
LOGGER.info("Registering service status handler");
ServiceStatus.setServiceStatusCallback(_instanceId, new
ServiceStatus.MultipleCallbackServiceStatusCallback(
- ImmutableList.of(new
ServiceStatus.IdealStateAndCurrentStateMatchServiceStatusCallback(_participantHelixManager,
+ List.of(
+ new ServiceStatus.LifecycleServiceStatusCallback(this::isStarting,
this::isShuttingDown),
+ new
ServiceStatus.IdealStateAndCurrentStateMatchServiceStatusCallback(_participantHelixManager,
_clusterName, _instanceId, resourcesToMonitor,
minResourcePercentForStartup),
new
ServiceStatus.IdealStateAndExternalViewMatchServiceStatusCallback(_participantHelixManager,
- _clusterName, _instanceId, resourcesToMonitor,
minResourcePercentForStartup),
- new ServiceStatus.LifecycleServiceStatusCallback(this::isStarting,
this::isShuttingDown))));
+ _clusterName, _instanceId, resourcesToMonitor,
minResourcePercentForStartup))));
}
private String getDefaultBrokerId() {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
