krishan1390 commented on code in PR #16585:
URL: https://github.com/apache/pinot/pull/16585#discussion_r2272929854


##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##########
@@ -489,132 +493,149 @@ public synchronized void 
buildRoutingForLogicalTable(String logicalTableName) {
    * Builds the routing for a table.
    * @param tableNameWithType the name of the table

Review Comment:
   the issue seen was in contention between helix threads calling 
refreshSegment() and ClusterChangeHandlingThread calling processClusterChange() 
   
   they're still synchronized on global lock. can we move those too to table 
level locks ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to