9aman commented on code in PR #16492:
URL: https://github.com/apache/pinot/pull/16492#discussion_r2262222231
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConfig.java:
##########
@@ -199,6 +203,12 @@ public StreamConfig(String tableNameWithType, Map<String,
String> streamConfigMa
String rate =
streamConfigMap.get(StreamConfigProperties.TOPIC_CONSUMPTION_RATE_LIMIT);
_topicConsumptionRateLimit = rate != null ? Double.parseDouble(rate) :
CONSUMPTION_RATE_LIMIT_NOT_SPECIFIED;
+ _enableOffsetAutoReset =
Boolean.parseBoolean(streamConfigMap.get(StreamConfigProperties.ENABLE_OFFSET_AUTO_RESET));
+ String offsetThreshold =
streamConfigMap.get(StreamConfigProperties.OFFSET_AUTO_RESET_OFFSET_THRESHOLD_KEY);
+ _offsetAutoResetOffsetThreshold = offsetThreshold != null ?
Integer.valueOf(offsetThreshold) : -1;
Review Comment:
A NumberFormatException would be thrown for invalid numbers. Suggest using
an approach similar to `extractFlushThresholdRows`
Failure here would lead to paused ingestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
