gortiz commented on code in PR #16475:
URL: https://github.com/apache/pinot/pull/16475#discussion_r2260760197
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/GrpcMailboxServer.java:
##########
@@ -84,6 +90,7 @@ public GrpcMailboxServer(MailboxService mailboxService,
PinotConfiguration confi
NettyServerBuilder builder = NettyServerBuilder
.forPort(port)
+ .intercept(new AuthorizationInterceptor(accessControlFactory))
Review Comment:
nit: Instead of supporting a nullable accessControlFactory... why don't we
just skip the intercept registration if accessControlFactory is null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
