deemoliu commented on code in PR #16507:
URL: https://github.com/apache/pinot/pull/16507#discussion_r2258385870
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/TableConfigUtilsTest.java:
##########
@@ -815,6 +815,57 @@ public void ingestionStreamConfigsTest() {
// Legacy behavior: allow size based threshold to be explicitly set to 0
streamConfigs.put(StreamConfigProperties.SEGMENT_FLUSH_THRESHOLD_ROWS,
"0");
TableConfigUtils.validateStreamConfig(new StreamConfig("test",
streamConfigs));
+
Review Comment:
streamconfigMap validation should not be test in
ingestionStreamConfigsTest().
this is because streamconfigMap can be either in ingestionconfig or
indexingConfig.
see
https://github.com/apache/pinot/blob/78dabced284493933d526e2fce61f239443bf5f1/pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java#L71C5-L71C87
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -622,6 +622,13 @@ private static void validateStreamConfigMaps(TableConfig
tableConfig) {
streamConfigs.add(streamConfig);
}
if (numStreamConfigs > 1) {
+ IngestionConfig ingestionConfig = tableConfig.getIngestionConfig();
Review Comment:
update to
if (ingestionConfig != null && ingestionConfig.getStreamIngestionConfig() !=
null) {
Preconditions.checkState(
!tableConfig.getIngestionConfig().getStreamIngestionConfig().isPauselessConsumptionEnabled(),
"Multiple stream configs are not supported with pauseless
consumption enabled");
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
