ankitsultana commented on code in PR #16442:
URL: https://github.com/apache/pinot/pull/16442#discussion_r2254834511
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -1945,10 +1945,12 @@ private long setQueryTimeout(String tableNameWithType,
Long logicalTableQueryTim
// Use query-level timeout if exists
queryTimeoutMs = queryLevelTimeoutMs;
} else {
- Long tableLevelTimeoutMs =
_routingManager.getQueryTimeoutMs(tableNameWithType);
- if (tableLevelTimeoutMs != null) {
+ TableConfig tableConfig = _tableCache.getTableConfig(tableNameWithType);
Review Comment:
before we were getting timeout from RoutingEntry, which was getting created
async and was getting the timeout from Table Config retrieved from
ZKMetadataProvider.
Now we are getting it from tableCache synchronously in the query path. I
suppose this should be fine, but just leaving a note here to call it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
