Copilot commented on code in PR #16489: URL: https://github.com/apache/pinot/pull/16489#discussion_r2250138547
########## pinot-controller/src/main/resources/app/components/TimezoneSelector.tsx: ########## @@ -0,0 +1,192 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import React, { useState, useEffect } from 'react'; +import { + Select, + MenuItem, + FormControl, + InputLabel, + makeStyles, + Typography, + Box, + TextField, + ListItemText, + Divider, +} from '@material-ui/core'; +import { AccessTime as AccessTimeIcon } from '@material-ui/icons'; +import { useTimezone } from '../contexts/TimezoneContext'; +import { COMMON_TIMEZONES, getAllTimezones, getTimezoneDisplayName } from '../utils/TimezoneUtils'; + +// Default maximum number of timezone results to display in the dropdown. +// This limit is set to prevent performance issues and overwhelming the user with too many options. +// Adjust as needed based on UI requirements or make configurable via props. +const MAX_TIMEZONE_RESULTS = 100; Review Comment: [nitpick] The MAX_TIMEZONE_RESULTS constant should be configurable via props rather than hardcoded, as mentioned in the comment. Consider adding it as an optional prop with the current value as default. ```suggestion ``` ########## pinot-controller/src/main/resources/app/pages/SegmentDetails.tsx: ########## @@ -98,11 +100,14 @@ type Props = { type Summary = { segmentName: string; totalDocs: string | number; - createTime: unknown; + createTime: unknown; // Raw timestamp for timezone-aware formatting; validate before use Review Comment: The comment suggests validation is needed but the type 'unknown' is too broad. Consider using a more specific type like 'number | null | undefined' to better express the expected timestamp values. ```suggestion createTime: number | null | undefined; // Raw timestamp for timezone-aware formatting; validate before use ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
