praveenc7 commented on code in PR #16360:
URL: https://github.com/apache/pinot/pull/16360#discussion_r2243386920
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/Tracing.java:
##########
@@ -323,25 +344,35 @@ public static void clear() {
public static void initializeThreadAccountant(PinotConfiguration config,
String instanceId,
Review Comment:
@vrajat Is there a reason other than backward compatibility we want to still
keep this interface around? I don't see it used anywhere other than some test.
Maybe we can replace it with `createThreadAccountant` for those handful of
cases, It might create confusion when to you what, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
