krishan1390 commented on code in PR #16362:
URL: https://github.com/apache/pinot/pull/16362#discussion_r2212232663
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -153,6 +153,7 @@ public abstract class BaseTableDataManager implements
TableDataManager {
protected volatile Pair<TableConfig, Schema> _cachedTableConfigAndSchema;
protected volatile boolean _shutDown;
+ protected volatile boolean _isDeleteTable;
Review Comment:
do we need another flag or would shutdown itself be sufficient to identify
if table is getting closed / deleted ? I see that we're setting shutdown flag
during table deletion and HelixInstanceDataManager.shutdown() method.
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -153,6 +153,7 @@ public abstract class BaseTableDataManager implements
TableDataManager {
protected volatile Pair<TableConfig, Schema> _cachedTableConfigAndSchema;
protected volatile boolean _shutDown;
+ protected volatile boolean _isDeleteTable;
Review Comment:
nit - would a better name be _isBeingDeleted or _isDeleted ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
