somandal commented on code in PR #16341:
URL: https://github.com/apache/pinot/pull/16341#discussion_r2210667991
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##########
@@ -365,22 +366,32 @@ private RebalancePreCheckerResult
checkRebalanceConfig(RebalanceConfig rebalance
}
Review Comment:
that's an existing check for the following reasons:
- If numReplicas = 1, then rebalance is not possible without downtime = true
or minAvailableReplicas = 0 (which also implies downtime rebalance as 0
replicas need to be up)
- If numReplicas > 1, we don't recommend downtime = true unless the caller
knows what they're doing. So we just return a warning so that the caller can
double check that they've intentionally set this flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
