Jackie-Jiang commented on PR #16348: URL: https://github.com/apache/pinot/pull/16348#issuecomment-3076186778
> * I think your PR addresses the case where we don't include consuming segments, but if we include consuming segments, they might still be moved, right? Yes. We still need to rely on peer download when consuming segments are moved, or introduce a new check to wait until commit is done. The change in this PR is to treat COMMITTING segment as CONSUMING instead of ONLINE to prevent periodic task to move them. > * My understanding is that if a segment is in COMMITTING state, eventually RealtimeSegmentValidationManager will run and fix it up (which means this scenario should be handled eventually to get the segment into a good state). Is this not the case if the segment undergoes rebalance? Ideally this is the case, but moving COMMITTING segment in periodic task is bad, and can cause consumption to rewind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
