J-HowHuang commented on code in PR #16202:
URL: https://github.com/apache/pinot/pull/16202#discussion_r2196094440
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##########
@@ -386,23 +394,38 @@ private void
persistInstancePartitionsHelper(InstancePartitions instancePartitio
}
}
- private String getTablesServedFromServerTenant(String tenantName, @Nullable
String database) {
+ private String getTablesServedFromServerTenant(String tenantName, @Nullable
String database,
+ boolean withTableProperties) {
Set<String> tables = new HashSet<>();
+ Set<TenantTableWithProperties> tablePropertiesMap = withTableProperties ?
new HashSet<>() : null;
Review Comment:
Change the type to Map instead (`tableNameWithType` to
`TenantTableWithProperties`), which make more sense as we don't want to hash
the whole object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
