rsrkpatwari1234 commented on code in PR #16244:
URL: https://github.com/apache/pinot/pull/16244#discussion_r2194536790
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java:
##########
@@ -423,6 +424,11 @@ private SuccessResponse uploadSegment(@Nullable String
tableName, TableType tabl
return new SuccessResponse("Successfully uploaded segment: " +
segmentName + " of table: " + tableNameWithType);
} catch (WebApplicationException e) {
throw e;
+ } catch (FileNotFoundException e) {
Review Comment:
/segments controller API hit this exception when incorrect segment download
HDFS path is provided for the offline pinot table. This is just one example.
There are a lot of flows where the SegmentFetcherFactory.fetchSegmentToLocal is
called -> FileNotFound exception can occur for any of those flows and for all
of them, it will unnecessarily retry for max # of attempts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
