This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 0def343561 Fixes incorrect logging in 
IngestionBasedConsumptionStatusChecker (#16252)
0def343561 is described below

commit 0def343561acad23fa9ee3eb74caf43ef702bb79
Author: NOOB <43700604+noob-se...@users.noreply.github.com>
AuthorDate: Wed Jul 2 01:48:35 2025 +0530

    Fixes incorrect logging in IngestionBasedConsumptionStatusChecker (#16252)
---
 .../starter/helix/IngestionBasedConsumptionStatusChecker.java       | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git 
a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/IngestionBasedConsumptionStatusChecker.java
 
b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/IngestionBasedConsumptionStatusChecker.java
index 18d08dd3d5..df8081f136 100644
--- 
a/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/IngestionBasedConsumptionStatusChecker.java
+++ 
b/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/IngestionBasedConsumptionStatusChecker.java
@@ -143,8 +143,6 @@ public abstract class 
IngestionBasedConsumptionStatusChecker {
       // Kafka's "latest" offset is actually the next available offset. 
Therefore it will be 1 ahead of the
       // current offset in the case we are caught up.
       // TODO: implement a way to have this work correctly for kafka consumers
-      _logger.info("Null offset found for segment {} - current offset: {}, 
latest offset: {}. "
-          + "Will check consumption status later", segmentName, currentOffset, 
latestOffset);
       try {
         return currentOffset.compareTo(latestOffset) >= 0;
       } catch (NullPointerException e) {
@@ -154,6 +152,10 @@ public abstract class 
IngestionBasedConsumptionStatusChecker {
             + "Will check consumption status later", segmentName, 
currentOffset, latestOffset);
       }
     }
+    _logger.info(
+        "Null offset found for segment: {} - current offset: {}, latest 
offset: {}. Will check consumption status "
+            + "later",
+        segmentName, currentOffset, latestOffset);
     return false;
   }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to