vrajat commented on code in PR #16219: URL: https://github.com/apache/pinot/pull/16219#discussion_r2176409597
########## pinot-core/src/test/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactoryTest.java: ########## @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.accounting; + +import java.util.HashMap; +import java.util.Map; +import java.util.Set; +import org.apache.pinot.spi.config.instance.InstanceType; +import org.apache.pinot.spi.env.PinotConfiguration; +import org.apache.pinot.spi.utils.CommonConstants; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + +import static org.testng.Assert.assertEquals; +import static org.testng.Assert.assertTrue; + + +public class PerQueryCPUMemAccountantFactoryTest { + private static final double EXPECTED_MIN_MEMORY_FOOTPRINT_FOR_KILL = 0.05; + private static final double EXPECTED_PANIC_LEVEL = 0.9f; + private static final double EXPECTED_CRITICAL_LEVEL = 0.95f; + private static final double EXPECTED_CRITICAL_LEVEL_AFTER_GC = 0.05f; + private static final int EXPECTED_GC_BACKOFF_COUNT = 3; + private static final double EXPECTED_ALARMING_LEVEL = 0.8f; + private static final int EXPECTED_NORMAL_SLEEP_TIME = 50; + private static final int EXPECTED_GC_WAIT_TIME = 1000; + private static final int EXPECTED_ALARMING_SLEEP_TIME_DENOMINATOR = 2; + private static final boolean EXPECTED_OOM_KILL_QUERY_ENABLED = true; + private static final boolean EXPECTED_PUBLISH_HEAP_USAGE_METRIC = true; + private static final boolean EXPECTED_IS_CPU_TIME_BASED_KILLING_ENABLED = true; + private static final long EXPECTED_CPU_TIME_BASED_KILLING_THRESHOLD_NS = 1000; + private static final boolean EXPECTED_IS_QUERY_KILLED_METRIC_ENABLED = true; + private static final Map<String, String> CLUSTER_CONFIGS = new HashMap<>(); + + private static String getFullyQualifiedConfigName(String config) { + return CommonConstants.PINOT_QUERY_SCHEDULER_PREFIX + "." + config; + } + + @BeforeClass + public void setUp() { + CLUSTER_CONFIGS.put(getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_OOM_PROTECTION_KILLING_QUERY), + Boolean.toString(EXPECTED_OOM_KILL_QUERY_ENABLED)); + CLUSTER_CONFIGS.put(getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_PUBLISHING_JVM_USAGE), + Boolean.toString(EXPECTED_PUBLISH_HEAP_USAGE_METRIC)); + CLUSTER_CONFIGS.put( + getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_CPU_TIME_BASED_KILLING_ENABLED), + Boolean.toString(EXPECTED_IS_CPU_TIME_BASED_KILLING_ENABLED)); + CLUSTER_CONFIGS.put( + getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_CPU_TIME_BASED_KILLING_THRESHOLD_MS), + Long.toString(EXPECTED_CPU_TIME_BASED_KILLING_THRESHOLD_NS)); + CLUSTER_CONFIGS.put(getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_PANIC_LEVEL_HEAP_USAGE_RATIO), + Double.toString(EXPECTED_PANIC_LEVEL)); + CLUSTER_CONFIGS.put( + getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_CRITICAL_LEVEL_HEAP_USAGE_RATIO), + Double.toString(EXPECTED_CRITICAL_LEVEL)); + CLUSTER_CONFIGS.put(getFullyQualifiedConfigName( + CommonConstants.Accounting.CONFIG_OF_CRITICAL_LEVEL_HEAP_USAGE_RATIO_DELTA_AFTER_GC), + Double.toString(EXPECTED_CRITICAL_LEVEL_AFTER_GC)); + CLUSTER_CONFIGS.put( + getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_ALARMING_LEVEL_HEAP_USAGE_RATIO), + Double.toString(EXPECTED_ALARMING_LEVEL)); + CLUSTER_CONFIGS.put(getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_SLEEP_TIME_MS), + Integer.toString(EXPECTED_NORMAL_SLEEP_TIME)); + CLUSTER_CONFIGS.put(getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_SLEEP_TIME_DENOMINATOR), + Integer.toString(EXPECTED_ALARMING_SLEEP_TIME_DENOMINATOR)); + CLUSTER_CONFIGS.put( + getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_MIN_MEMORY_FOOTPRINT_TO_KILL_RATIO), + Double.toString(EXPECTED_MIN_MEMORY_FOOTPRINT_FOR_KILL)); + CLUSTER_CONFIGS.put(getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_GC_BACKOFF_COUNT), + Integer.toString(EXPECTED_GC_BACKOFF_COUNT)); + CLUSTER_CONFIGS.put(getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_GC_WAIT_TIME_MS), + Integer.toString(EXPECTED_GC_WAIT_TIME)); + CLUSTER_CONFIGS.put(getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_QUERY_KILLED_METRIC_ENABLED), + Boolean.toString(EXPECTED_IS_QUERY_KILLED_METRIC_ENABLED)); + } + + @Test + void testOOMProtectionKillingQueryConfigChange() { + PerQueryCPUMemAccountantFactory.PerQueryCPUMemResourceUsageAccountant accountant = + new PerQueryCPUMemAccountantFactory.PerQueryCPUMemResourceUsageAccountant(new PinotConfiguration(), "test", + InstanceType.SERVER); + + accountant.getWatcherTask().onChange( + Set.of(getFullyQualifiedConfigName(CommonConstants.Accounting.CONFIG_OF_OOM_PROTECTION_KILLING_QUERY)), Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
