ankitsultana commented on code in PR #16240:
URL: https://github.com/apache/pinot/pull/16240#discussion_r2176140085
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -492,6 +492,41 @@ public static class Broker {
"pinot.broker.enable.dynamic.filtering.semijoin";
public static final boolean DEFAULT_ENABLE_DYNAMIC_FILTERING_SEMI_JOIN =
true;
+ /**
+ * Whether to use physical optimizer by default.
+ * This value can always be overridden by {@link
Request.QueryOptionKey#USE_PHYSICAL_OPTIMIZER} query option
+ */
+ public static final String CONFIG_OF_USE_PHYSICAL_OPTIMIZER =
"pinot.broker.use.physical.optimizer";
+ public static final boolean DEFAULT_USE_PHYSICAL_OPTIMIZER = true;
+
+ /**
+ * Whether to use lite mode by default.
+ * This value can always be overridden by {@link
Request.QueryOptionKey#USE_LITE_MODE} query option
+ */
+ public static final String CONFIG_OF_USE_LITE_MODE =
"pinot.broker.use.lite.mode";
+ public static final boolean DEFAULT_USE_LITE_MODE = false;
+
+ /**
+ * Whether to run in broker by default.
+ * This value can always be overridden by {@link
Request.QueryOptionKey#RUN_IN_BROKER} query option
+ */
+ public static final String CONFIG_OF_RUN_IN_BROKER =
"pinot.broker.run.in.broker";
+ public static final boolean DEFAULT_RUN_IN_BROKER = true;
+
+ /**
+ * Whether to use broker pruning by default.
+ * This value can always be overridden by {@link
Request.QueryOptionKey#USE_BROKER_PRUNING} query option
+ */
+ public static final String CONFIG_OF_USE_BROKER_PRUNING =
"pinot.broker.use.broker.pruning";
+ public static final boolean DEFAULT_USE_BROKER_PRUNING = true;
+
+ /**
+ * Default server stage limit for lite mode queries.
+ * This value can always be overridden by {@link
Request.QueryOptionKey#LITE_MODE_SERVER_STAGE_LIMIT} query option
+ */
+ public static final String CONFIG_OF_LITE_MODE_SERVER_STAGE_LIMIT =
"pinot.broker.lite.mode.server.stage.limit";
Review Comment:
On further thought: could we name this to "leaf stage limit" instead?
Server stage limit might be slightly misleading because lite mode can also
run in the mode where intermediate stages run in a random server
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -492,6 +492,41 @@ public static class Broker {
"pinot.broker.enable.dynamic.filtering.semijoin";
public static final boolean DEFAULT_ENABLE_DYNAMIC_FILTERING_SEMI_JOIN =
true;
+ /**
+ * Whether to use physical optimizer by default.
+ * This value can always be overridden by {@link
Request.QueryOptionKey#USE_PHYSICAL_OPTIMIZER} query option
+ */
+ public static final String CONFIG_OF_USE_PHYSICAL_OPTIMIZER =
"pinot.broker.use.physical.optimizer";
Review Comment:
Would recommend to keep the prefix: `pinot.broker.multistage` rather than
just `pinot.broker`.
To be consistent with
`CONFIG_OF_BROKER_ENABLE_MULTISTAGE_MIGRATION_METRIC`,`CONFIG_OF_SPOOLS`, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
