songwdfu commented on code in PR #16123:
URL: https://github.com/apache/pinot/pull/16123#discussion_r2175510939
##########
pinot-common/src/main/proto/plan.proto:
##########
@@ -103,6 +104,35 @@ message JoinNode {
Expression matchCondition = 6;
}
+enum FilterProjectRexType {
+ FILTER = 0;
+ PROJECT = 1;
+}
+
+message ProjectAndResultSchema {
+ repeated Expression project = 1;
+ DataSchema schema = 2;
+}
+
+message FilterProjectRex {
+ FilterProjectRexType type = 1;
+ optional Expression filter = 2;
+ optional ProjectAndResultSchema projectAndResultSchema = 3;
+}
+
+message EnrichedJoinNode {
+ JoinType joinType = 1;
+ repeated int32 leftKeys = 2;
+ repeated int32 rightKeys = 3;
+ repeated Expression nonEquiConditions = 4;
+ JoinStrategy joinStrategy = 5;
+ Expression matchCondition = 6;
+ repeated FilterProjectRex filterProjectRex = 7;
+ DataSchema joinResultDataSchema = 8;
+ int32 fetch = 9;
+ int32 offset = 10;
Review Comment:
I think offset changes total number of rows emitted? If total N rows offset
X, we should emit only N-X rows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
