This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e810c3e7bf6 Removes Ingestion Metrics of Inactive Partitions from the
Committing Server (#16173)
e810c3e7bf6 is described below
commit e810c3e7bf6c6d50b5f679c6702c7024e646eb99
Author: NOOB <43700604+noob-se...@users.noreply.github.com>
AuthorDate: Fri Jun 27 04:07:42 2025 +0530
Removes Ingestion Metrics of Inactive Partitions from the Committing Server
(#16173)
---
.../data/manager/realtime/RealtimeTableDataManager.java | 15 ++-------------
.../segment/local/data/manager/TableDataManager.java | 8 --------
2 files changed, 2 insertions(+), 21 deletions(-)
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
index e56e937b992..ab36b37eaaf 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
@@ -335,18 +335,6 @@ public class RealtimeTableDataManager extends
BaseTableDataManager {
_ingestionDelayTracker.stopTrackingPartitionIngestionDelay(new
LLCSegmentName(segmentName).getPartitionGroupId());
}
- /**
- * Method to handle CONSUMING -> ONLINE segment state transitions:
- * We mark partitions for verification against ideal state when we do not
see a consuming segment for some time
- * for that partition. The idea is to remove the related metrics when the
partition moves from the current server.
- *
- * @param segmentName name of segment which is transitioning state.
- */
- @Override
- public void onConsumingToOnline(String segmentName) {
- _ingestionDelayTracker.markPartitionForVerification(segmentName);
- }
-
@Override
public List<SegmentContext> getSegmentContexts(List<IndexSegment>
selectedSegments,
Map<String, String> queryOptions) {
@@ -470,7 +458,6 @@ public class RealtimeTableDataManager extends
BaseTableDataManager {
} else if (segmentDataManager instanceof RealtimeSegmentDataManager) {
_logger.info("Changing segment: {} from CONSUMING to ONLINE",
segmentName);
((RealtimeSegmentDataManager)
segmentDataManager).goOnlineFromConsuming(zkMetadata);
- onConsumingToOnline(segmentName);
} else if (zkMetadata.getStatus().isCompleted()) {
// For pauseless ingestion, the segment is marked ONLINE before it's
built and before the COMMIT_END_METADATA
// call completes.
@@ -852,6 +839,7 @@ public class RealtimeTableDataManager extends
BaseTableDataManager {
IndexLoadingConfig indexLoadingConfig = fetchIndexLoadingConfig();
indexLoadingConfig.setSegmentTier(zkMetadata.getTier());
addSegment(ImmutableSegmentLoader.load(indexDir, indexLoadingConfig,
_segmentOperationsThrottler), zkMetadata);
+ _ingestionDelayTracker.markPartitionForVerification(segmentName);
_logger.info("Downloaded and replaced CONSUMING segment: {}", segmentName);
}
@@ -878,6 +866,7 @@ public class RealtimeTableDataManager extends
BaseTableDataManager {
ImmutableSegmentLoader.load(indexDir, indexLoadingConfig,
_segmentOperationsThrottler);
addSegment(immutableSegment, zkMetadata);
+ _ingestionDelayTracker.markPartitionForVerification(segmentName);
_logger.info("Replaced CONSUMING segment: {}", segmentName);
}
diff --git
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java
index 5e64fd953bc..93446f57f10 100644
---
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java
+++
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java
@@ -332,14 +332,6 @@ public interface TableDataManager {
default void onConsumingToDropped(String segmentNameStr) {
}
- /**
- * Interface to handle segment state transitions from CONSUMING to ONLINE
- *
- * @param segmentNameStr name of segment for which the state change is being
handled
- */
- default void onConsumingToOnline(String segmentNameStr) {
- }
-
/**
* Return list of segment names that are stale along with reason.
*
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
