9aman commented on code in PR #16043: URL: https://github.com/apache/pinot/pull/16043#discussion_r2167037940
########## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/RowLevelSecurityIntegrationTest.java: ########## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.integration.tests; + +import com.fasterxml.jackson.databind.JsonNode; +import java.io.File; +import java.io.IOException; +import java.util.List; +import java.util.Map; +import org.apache.commons.io.FileUtils; +import org.apache.pinot.client.Connection; +import org.apache.pinot.client.ConnectionFactory; +import org.apache.pinot.client.JsonAsyncHttpPinotClientTransportFactory; +import org.apache.pinot.controller.helix.ControllerRequestClient; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.data.Schema; +import org.apache.pinot.spi.env.PinotConfiguration; +import org.apache.pinot.util.TestUtils; +import org.junit.Assert; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.testng.annotations.AfterClass; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + +import static org.apache.pinot.integration.tests.BasicAuthTestUtils.AUTH_HEADER; +import static org.apache.pinot.integration.tests.BasicAuthTestUtils.AUTH_HEADER_USER; +import static org.apache.pinot.integration.tests.BasicAuthTestUtils.AUTH_TOKEN; +import static org.apache.pinot.integration.tests.ClusterIntegrationTestUtils.getBrokerQueryApiUrl; + + +public class RowLevelSecurityIntegrationTest extends BaseClusterIntegrationTest { + private static final String AUTH_TOKEN_USER_2 = "Basic dXNlcjI6bm90U29TZWNyZXQ"; + public static final Map<String, String> AUTH_HEADER_USER_2 = Map.of("Authorization", AUTH_TOKEN_USER_2); + private static final String DEFAULT_TABLE_NAME_2 = "mytable2"; + private static final String DEFAULT_TABLE_NAME_3 = "mytable3"; + + protected List<File> _avroFiles; + private static final Logger LOGGER = LoggerFactory.getLogger(RowLevelSecurityIntegrationTest.class); + + @Override + protected void overrideControllerConf(Map<String, Object> properties) { + properties.put("controller.segment.fetcher.auth.token", AUTH_TOKEN); + properties.put("controller.admin.access.control.factory.class", + "org.apache.pinot.controller.api.access.BasicAuthAccessControlFactory"); + properties.put("controller.admin.access.control.principals", "admin, user, user2"); + properties.put("controller.admin.access.control.principals.admin.password", "verysecret"); + properties.put("controller.admin.access.control.principals.user.password", "secret"); + properties.put("controller.admin.access.control.principals.user2.password", "notSoSecret"); + properties.put("controller.admin.access.control.principals.user.tables", "mytable, mytable2, mytable3"); + properties.put("controller.admin.access.control.principals.user.permissions", "read"); + properties.put("controller.admin.access.control.principals.user2.tables", "mytable, mytable2, mytable3"); + properties.put("controller.admin.access.control.principals.user2.permissions", "read"); + } + + @Override + protected void overrideBrokerConf(PinotConfiguration brokerConf) { + brokerConf.setProperty("pinot.broker.access.control.class", + "org.apache.pinot.broker.broker.BasicAuthAccessControlFactory"); + brokerConf.setProperty("pinot.broker.access.control.principals", "admin, user, user2"); + brokerConf.setProperty("pinot.broker.access.control.principals.admin.password", "verysecret"); + brokerConf.setProperty("pinot.broker.access.control.principals.user.password", "secret"); + brokerConf.setProperty("pinot.broker.access.control.principals.user2.password", "notSoSecret"); + brokerConf.setProperty("pinot.broker.access.control.principals.user.tables", "mytable, mytable2, mytable3"); + brokerConf.setProperty("pinot.broker.access.control.principals.user.permissions", "read"); + brokerConf.setProperty("pinot.broker.access.control.principals.user.mytable.rls", "AirlineID='19805'"); + brokerConf.setProperty("pinot.broker.access.control.principals.user.mytable3.rls", + "AirlineID='20409' OR AirTime>'300', DestStateName='Florida'"); + brokerConf.setProperty("pinot.broker.access.control.principals.user2.tables", "mytable, mytable2, mytable3"); + brokerConf.setProperty("pinot.broker.access.control.principals.user2.permissions", "read"); + brokerConf.setProperty("pinot.broker.access.control.principals.user2.mytable.rls", + "AirlineID='19805', DestStateName='California'"); + brokerConf.setProperty("pinot.broker.access.control.principals.user2.mytable2.rls", + "AirlineID='20409', DestStateName='Florida'"); + brokerConf.setProperty("pinot.broker.access.control.principals.user2.mytable3.rls", + "AirlineID='20409' OR DestStateName='California', DestStateName='Florida'"); + } + + @Override + protected void overrideServerConf(PinotConfiguration serverConf) { + serverConf.setProperty("pinot.server.segment.fetcher.auth.token", AUTH_TOKEN); + serverConf.setProperty("pinot.server.segment.uploader.auth.token", AUTH_TOKEN); + serverConf.setProperty("pinot.server.instance.auth.token", AUTH_TOKEN); + } + + @Override + public ControllerRequestClient getControllerRequestClient() { + if (_controllerRequestClient == null) { + _controllerRequestClient = + new ControllerRequestClient(_controllerRequestURLBuilder, getHttpClient(), AUTH_HEADER); + } + return _controllerRequestClient; + } + + @Override + protected Connection getPinotConnection() { + if (_pinotConnection == null) { + JsonAsyncHttpPinotClientTransportFactory factory = new JsonAsyncHttpPinotClientTransportFactory(); + factory.setHeaders(AUTH_HEADER); + + _pinotConnection = + ConnectionFactory.fromZookeeper(getZkUrl() + "/" + getHelixClusterName(), factory.buildTransport()); + } + return _pinotConnection; + } + + @BeforeClass + public void setUp() + throws Exception { + TestUtils.ensureDirectoriesExistAndEmpty(_tempDir, _segmentDir, _tarDir); + startZk(); + startController(); + startBroker(); + startServer(); + + startKafka(); + _avroFiles = unpackAvroData(_tempDir); + pushAvroIntoKafka(_avroFiles); + + // Set up a table for testing different principals. + setupTable(DEFAULT_TABLE_NAME); + setupTable(DEFAULT_TABLE_NAME_2); + setupTable(DEFAULT_TABLE_NAME_3); + + waitForAllDocsLoaded(600_000L); + } + + private void setupTable(String tableName) + throws Exception { + + Schema schema = createSchema(); + schema.setSchemaName(tableName); + addSchema(schema); + + TableConfig tableConfig = createRealtimeTableConfig(_avroFiles.get(0)); + tableConfig.setTableName(tableName); + tableConfig.getValidationConfig().setRetentionTimeUnit("DAYS"); + tableConfig.getValidationConfig().setRetentionTimeValue("100000"); + addTableConfig(tableConfig); + + waitForDocsLoaded(600_000L, true, tableConfig.getTableName()); + } + + @AfterClass + public void tearDown() + throws IOException { + LOGGER.info("Tearing down..."); + dropRealtimeTable(getTableName()); + stopServer(); + stopBroker(); + stopController(); + stopKafka(); + stopZk(); + FileUtils.deleteDirectory(_tempDir); + } + + @Test + public void testRowFiltersForSingleStateQuery() Review Comment: Fxied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
