shauryachats commented on code in PR #16105:
URL: https://github.com/apache/pinot/pull/16105#discussion_r2164876924


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java:
##########
@@ -728,6 +728,29 @@ public SimpleHttpResponse uploadSegment(URI uri, String 
segmentName, File segmen
     return uploadSegment(uri, segmentName, segmentFile, null, parameters, 
HttpClient.DEFAULT_SOCKET_TIMEOUT_MS);
   }
 
+  /**
+   * Upload segment with segment file using default settings. Include table 
name and type as a request parameters.

Review Comment:
   Right. The above method is used in many places hence had to create a new one 
which allowed headers to be passed through, to avoid unnecessary changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to