9aman commented on code in PR #15996:
URL: https://github.com/apache/pinot/pull/15996#discussion_r2161266878
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -1246,15 +1250,45 @@ public SuccessResponse deleteSegmentsFromSequenceNum(
Map<Integer, Set<String>> partitionIdToSegmentsToDeleteMap =
getPartitionIdToSegmentsToDeleteMap(partitionToOldestSegment,
idealStateSegmentsSet,
partitionIdToLatestSegment);
+
+ Map<String, Object> response = new HashMap<>();
+ Map<String, Object> partitionDetails = new HashMap<>();
Review Comment:
Done. Yes, the interger does help with the readability
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -1246,15 +1250,45 @@ public SuccessResponse deleteSegmentsFromSequenceNum(
Map<Integer, Set<String>> partitionIdToSegmentsToDeleteMap =
getPartitionIdToSegmentsToDeleteMap(partitionToOldestSegment,
idealStateSegmentsSet,
partitionIdToLatestSegment);
+
+ Map<String, Object> response = new HashMap<>();
+ Map<String, Object> partitionDetails = new HashMap<>();
Review Comment:
Done. Yes, the integer does help with the readability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
