J-HowHuang commented on code in PR #16144:
URL: https://github.com/apache/pinot/pull/16144#discussion_r2159671819
##########
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##########
@@ -174,5 +174,15 @@ export const rebalanceServerOptions:
RebalanceServerOption[] = [
"isAdvancedConfig": true,
"isStatsGatheringConfig": false,
"markWithWarningIcon": false
+ },
+ {
+ "name": "diskUtilizationThreshold",
+ "defaultValue": -1.0,
+ "type": "DOUBLE",
+ "label": "Disk Utilization Threshold",
+ "description": "Override disk utilization threshold used in pre-check
(0.0 to 1.0, e.g., 0.85 for 85%). If not provided (or -1.0), uses the
controller's default threshold",
+ "isAdvancedConfig": true,
+ "isStatsGatheringConfig": false,
Review Comment:
It looks like it doesn't render options with `isStatsGatheringConfig=true`
afaik. The only option with this flag is `preChecks`.
@himanish-star should we set this to true or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
