rhodo commented on code in PR #16149:
URL: https://github.com/apache/pinot/pull/16149#discussion_r2155750554
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/realtime/converter/RealtimeSegmentConverterTest.java:
##########
@@ -473,8 +473,8 @@ private void testSegment(List<GenericRow> rows, File
indexDir,
public static Object[][] optimizeDictionaryTypeParams() {
// Format: {optimizeDictionaryType, expectedCRC}, crc is used here to
check the correct dictionary type was used
return new Object[][]{
- {true, "2653526366"},
- {false, "2948830084"},
+ {true, "3490760441"},
+ {false, "4243743"},
Review Comment:
it is expected that these crc values is changed because this PR write the
maxLengthExceedStrategy to the metadata even if it a effective default strategy
https://github.com/apache/pinot/pull/16149/files#diff-f77f250efb4d56b596a7991f65ff00139fb73463111619d64741bec4306efa1a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
