yashmayya commented on code in PR #16140: URL: https://github.com/apache/pinot/pull/16140#discussion_r2154823144
########## pinot-tools/src/main/java/org/apache/pinot/tools/RealtimeQuickStart.java: ########## @@ -99,7 +99,7 @@ public void execute() Preconditions.checkState(quickstartRunnerDir.mkdirs()); List<QuickstartTableRequest> quickstartTableRequests = bootstrapStreamTableDirectories(quickstartTmpDir); final QuickstartRunner runner = - new QuickstartRunner(quickstartTableRequests, 1, 1, 1, 1, quickstartRunnerDir, getConfigOverrides()); Review Comment: Ah, no, slipped through accidentally while testing. Although I'd like to include this change too because it makes testing instance assignment / segment assignment / rebalance scenarios much easier. The other quickstarts with multiple servers all seem to only have offline tables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org