This is an automated email from the ASF dual-hosted git repository.
somandal pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e556b0f1545 Use the RebalanceDiskUtilizationThreshold instead of
DiskUtilizationThreshold config for init() of the rebalance pre-checker (#16132)
e556b0f1545 is described below
commit e556b0f1545d28a081d0de61e2637dbd3c397d5f
Author: Sonam Mandal <sonam.man...@startree.ai>
AuthorDate: Tue Jun 17 15:03:02 2025 -0700
Use the RebalanceDiskUtilizationThreshold instead of
DiskUtilizationThreshold config for init() of the rebalance pre-checker (#16132)
---
.../main/java/org/apache/pinot/controller/BaseControllerStarter.java | 2 +-
.../controller/helix/core/rebalance/DefaultRebalancePreChecker.java | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java
index 8ab5c6ac27f..54854f0e5b0 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java
@@ -556,7 +556,7 @@ public abstract class BaseControllerStarter implements
ServiceStartable {
_diskUtilizationChecker = new
DiskUtilizationChecker(_helixResourceManager, _config);
_resourceUtilizationManager = new ResourceUtilizationManager(_config,
_diskUtilizationChecker);
_rebalancePreChecker =
RebalancePreCheckerFactory.create(_config.getRebalancePreCheckerClass());
- _rebalancePreChecker.init(_helixResourceManager, _executorService,
_config.getDiskUtilizationThreshold());
+ _rebalancePreChecker.init(_helixResourceManager, _executorService,
_config.getRebalanceDiskUtilizationThreshold());
_rebalancerExecutorService =
createExecutorService(_config.getControllerExecutorRebalanceNumThreads(),
"rebalance-thread-%d");
_tableRebalanceManager =
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java
index a893ada3bef..37a2f29970a 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java
@@ -98,7 +98,8 @@ public class DefaultRebalancePreChecker implements
RebalancePreChecker {
checkDiskUtilization(preCheckContext.getCurrentAssignment(),
preCheckContext.getTargetAssignment(),
preCheckContext.getTableSubTypeSizeDetails(),
_diskUtilizationThreshold, true));
// Check if all servers involved in the rebalance will have enough disk
space after the rebalance.
- // TODO: give this check a separate threshold other than the disk
utilization threshold
+ // TODO: Add the option to take disk utilization threshold as a
RebalanceConfig option and use that to override
+ // the default config
preCheckResult.put(DISK_UTILIZATION_AFTER_REBALANCE,
checkDiskUtilization(preCheckContext.getCurrentAssignment(),
preCheckContext.getTargetAssignment(),
preCheckContext.getTableSubTypeSizeDetails(),
_diskUtilizationThreshold, false));
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
