KKcorps commented on code in PR #16085:
URL: https://github.com/apache/pinot/pull/16085#discussion_r2150180485
##########
pinot-controller/src/main/resources/app/components/SimpleAccordion.tsx:
##########
@@ -120,13 +145,32 @@ export default function SimpleAccordion({
}
</AccordionSummary>
<AccordionDetails className={clsx(classes.details,
detailsContainerClass)}>
- {showSearchBox ?
- <SearchBar
- // searchOnRight={true}
- value={searchValue}
- onChange={(e) => handleSearch(e.target.value)}
- />
- : null}
+ {needsControlsContainer ? (
+ // New layout: search + additional controls in container
+ <div className={classes.controlsContainer}>
+ {showSearchBox && (
+ <div className={classes.searchBarContainer}>
Review Comment:
We are for this table
i tried reverting the changes in the accordion and the filter simple stops
showing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
