9aman commented on code in PR #16107:
URL: https://github.com/apache/pinot/pull/16107#discussion_r2147131294
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##########
@@ -301,6 +301,17 @@ private boolean shouldDeleteInProgressLLCSegment(String
segmentName, IdealState
private List<String> getSegmentsToDeleteFromDeepstore(String
tableNameWithType, RetentionStrategy retentionStrategy,
List<SegmentZKMetadata> segmentZKMetadataList, int
untrackedSegmentsDeletionBatchSize) {
List<String> segmentsToDelete = new ArrayList<>();
+ if (TableNameBuilder.isRealtimeTableResource(tableNameWithType)) {
Review Comment:
@swaminathanmanish the logic looks good to me.
The change relies on the fact that retention for OFFLINE > REALTIME and
hence the RetentionManager should only be concerned with OFFLINE tables run
when it comes to orphan segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
