wirybeaver commented on code in PR #16104:
URL: https://github.com/apache/pinot/pull/16104#discussion_r2146173429
##########
pinot-common/src/test/java/org/apache/pinot/common/metrics/BrokerMetricsTest.java:
##########
@@ -30,27 +30,33 @@
public class BrokerMetricsTest {
@Test
- public void testGetTagForPreferredGroup() {
+ public void testGetTagForPreferredPool() {
// Test case 1: queryOption is null
- assertEquals(BrokerMetrics.getTagForPreferredGroup(null),
"preferredGroupOptUnset",
- "Should return preferredGroupOptUnset when queryOption is null");
+ assertEquals(BrokerMetrics.getTagForPreferredPool(null),
"preferredPoolOptUnset",
+ "Should return preferredPoolOptUnset when queryOption is null");
// Test case 2: queryOption is empty
Map<String, String> emptyQueryOption = new HashMap<>();
- assertEquals(BrokerMetrics.getTagForPreferredGroup(emptyQueryOption),
"preferredGroupOptUnset",
- "Should return preferredGroupOptUnset when queryOption is empty");
+ assertEquals(BrokerMetrics.getTagForPreferredPool(emptyQueryOption),
"preferredPoolOptUnset",
+ "Should return preferredPoolOptUnset when queryOption is empty");
- // Test case 3: queryOption does not contain ORDERED_PREFERRED_REPLICAS
- Map<String, String> queryOptionWithoutPreferredGroup = new HashMap<>();
- queryOptionWithoutPreferredGroup.put("someOtherOption", "value");
-
assertEquals(BrokerMetrics.getTagForPreferredGroup(queryOptionWithoutPreferredGroup),
- "preferredGroupOptUnset",
- "Should return preferredGroupOptUnset when queryOption does not
contain ORDERED_PREFERRED_REPLICAS");
+ // Test case 3: queryOption does not contain ORDERED_PREFERRED_POOLS
+ Map<String, String> queryOptionWithoutPreferredPool = new HashMap<>();
+ queryOptionWithoutPreferredPool.put("someOtherOption", "value");
+
assertEquals(BrokerMetrics.getTagForPreferredPool(queryOptionWithoutPreferredPool),
+ "preferredPoolOptUnset",
+ "Should return preferredPoolOptUnset when queryOption does not contain
ORDERED_PREFERRED_POOLS");
- // Test case 4: queryOption contains ORDERED_PREFERRED_REPLICAS
+ // Test case 4: queryOption contains ORDERED_PREFERRED_POOLS
+ Map<String, String> queryOptionWithPreferredPool = new HashMap<>();
+ queryOptionWithPreferredPool.put("orderedPreferredPools", "0");
+
assertEquals(BrokerMetrics.getTagForPreferredPool(queryOptionWithPreferredPool),
"preferredPoolOptSet",
+ "Should return preferredPoolOptSet when queryOption contains
ORDERED_PREFERRED_POOLS");
+
+ // Test case 5: queryOption contains ORDERED_PREFERRED_REPLICAS
Map<String, String> queryOptionWithPreferredGroup = new HashMap<>();
queryOptionWithPreferredGroup.put("orderedPreferredReplicas", "0");
Review Comment:
yeah, the test case 5 is intentionally use the deprecated query option to
ensure the backward compatibility of the
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
