Jackie-Jiang commented on code in PR #16084:
URL: https://github.com/apache/pinot/pull/16084#discussion_r2146066704
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/DispatchablePlanContext.java:
##########
@@ -71,17 +88,32 @@ public long getRequestId() {
return _requestId;
}
+ public PlannerContext getPlannerContext() {
+ return _plannerContext;
+ }
+
+ public PairList<Integer, String> getResultFields() {
+ return _resultFields;
+ }
+
// Returns all the table names.
public Set<String> getTableNames() {
return _tableNames;
}
- public PairList<Integer, String> getResultFields() {
- return _resultFields;
+ /// Tracks non-lookup tables queried in leaf stages, which are used to
determine the servers to use for intermediate
+ /// stages. Returns `null` if leaf servers are directly used for
intermediate stages.
+ @Nullable
+ public Set<String> getNonLookupTables() {
+ return _nonLookupTables;
}
- public PlannerContext getPlannerContext() {
- return _plannerContext;
+ /// Tracks servers that are used for leaf stages, which are used to
determine the servers to use for intermediate
+ /// stages. Returns `null` if leaf servers are NOT directly used for
intermediate stages, and we need to calculate
+ /// the servers to use based on the non-lookup tables.
+ @Nullable
+ public Set<QueryServerInstance> getLeafServerInstances() {
+ return _leafServerInstances;
Review Comment:
Added an assert on `isUseLeafServerForIntermediateStage()` so that the
assumption is more clear. Removed the `@Nullable` annotation as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
