yashmayya commented on PR #16046: URL: https://github.com/apache/pinot/pull/16046#issuecomment-2971125158
The binary compatibility check is failing because we're moving `MAXIMUM_CONTROLLER_JOBS_IN_ZK` out of `CommonConstants` which is in `pinot-spi`. That is expected and I believe after merging this PR, the new baseline will be measured from `master` so there won't be failures in other PRs (unlike earlier, when we were using a manually generated baseline JAR - https://github.com/apache/pinot/pull/15982). I believe it's safe to move `MAXIMUM_CONTROLLER_JOBS_IN_ZK` out of `pinot-spi` / `CommonConstants` because it's something internal to how Pinot interacts with Helix / ZK and shouldn't have been used outside of the Pinot codebase anyway. I'm going ahead and merging this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
