wirybeaver commented on code in PR #15958:
URL: https://github.com/apache/pinot/pull/15958#discussion_r2141672531
##########
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotRuleUtils.java:
##########
@@ -122,4 +135,129 @@ public static String extractFunctionName(RexCall
function) {
SqlKind funcSqlKind = function.getOperator().getKind();
return funcSqlKind == SqlKind.OTHER_FUNCTION ?
function.getOperator().getName() : funcSqlKind.name();
}
+
+ public static class WindowUtils {
+ // Supported window functions
+ // OTHER_FUNCTION supported are: BOOL_AND, BOOL_OR
+ private static final EnumSet<SqlKind> SUPPORTED_WINDOW_FUNCTION_KIND =
+ EnumSet.of(SqlKind.SUM, SqlKind.SUM0, SqlKind.MIN, SqlKind.MAX,
SqlKind.COUNT, SqlKind.ROW_NUMBER, SqlKind.RANK,
+ SqlKind.DENSE_RANK, SqlKind.NTILE, SqlKind.LAG, SqlKind.LEAD,
SqlKind.FIRST_VALUE, SqlKind.LAST_VALUE,
+ SqlKind.OTHER_FUNCTION);
+
+ public static void validateWindows(Window window) {
+ int numGroups = window.groups.size();
+ // For Phase 1 we only handle single window groups
+ Preconditions.checkState(numGroups == 1,
+ String.format("Currently only 1 window group is supported, query has
%d groups", numGroups));
+
+ // Validate that only supported window aggregation functions are present
+ Window.Group windowGroup = window.groups.get(0);
+ validateWindowAggCallsSupported(windowGroup);
+
+ // Validate the frame
+ validateWindowFrames(windowGroup);
+ }
+
+ /**
+ * Replaces the reference to literal arguments in the window group with
the actual literal values.
+ * NOTE: {@link Window} has a field called "constants" which contains the
literal values. If the input reference is
+ * beyond the window input size, it is a reference to the constants.
+ */
+ public static Window.Group updateLiteralArgumentsInWindowGroup(Window
window) {
+ Window.Group oldWindowGroup = window.groups.get(0);
+ RelNode input = unboxRel(window.getInput());
+ int numInputFields = input.getRowType().getFieldCount();
+ List<RexNode> projects = input instanceof Project ? ((Project)
input).getProjects() : null;
+
+ List<Window.RexWinAggCall> newAggCallWindow = new
ArrayList<>(oldWindowGroup.aggCalls.size());
+ boolean windowChanged = false;
+ for (Window.RexWinAggCall oldAggCall : oldWindowGroup.aggCalls) {
+ boolean changed = false;
+ List<RexNode> oldOperands = oldAggCall.getOperands();
+ List<RexNode> newOperands = new ArrayList<>(oldOperands.size());
+ for (RexNode oldOperand : oldOperands) {
+ RexLiteral literal = getLiteral(oldOperand, numInputFields,
window.constants, projects);
+ if (literal != null) {
+ newOperands.add(literal);
+ changed = true;
+ windowChanged = true;
+ } else {
+ newOperands.add(oldOperand);
+ }
+ }
+ if (changed) {
+ newAggCallWindow.add(
+ new Window.RexWinAggCall((SqlAggFunction)
oldAggCall.getOperator(), oldAggCall.type, newOperands,
+ oldAggCall.ordinal, oldAggCall.distinct,
oldAggCall.ignoreNulls));
+ } else {
+ newAggCallWindow.add(oldAggCall);
+ }
+ }
+
+ RexWindowBound lowerBound = oldWindowGroup.lowerBound;
+ RexNode offset = lowerBound.getOffset();
+ if (offset != null) {
+ RexLiteral literal = getLiteral(offset, numInputFields,
window.constants, projects);
+ if (literal == null) {
+ throw new IllegalStateException(
+ "Could not read window lower bound literal value from window
group: " + oldWindowGroup);
+ }
+ lowerBound = lowerBound.isPreceding() ?
RexWindowBounds.preceding(literal) : RexWindowBounds.following(literal);
+ windowChanged = true;
+ }
+ RexWindowBound upperBound = oldWindowGroup.upperBound;
+ offset = upperBound.getOffset();
+ if (offset != null) {
+ RexLiteral literal = getLiteral(offset, numInputFields,
window.constants, projects);
+ if (literal == null) {
+ throw new IllegalStateException(
+ "Could not read window upper bound literal value from window
group: " + oldWindowGroup);
+ }
+ upperBound = upperBound.isFollowing() ?
RexWindowBounds.following(literal) : RexWindowBounds.preceding(literal);
+ windowChanged = true;
+ }
+
+ return windowChanged ? new Window.Group(oldWindowGroup.keys,
oldWindowGroup.isRows, lowerBound, upperBound,
+ oldWindowGroup.exclude, oldWindowGroup.orderKeys, newAggCallWindow)
: oldWindowGroup;
+ }
+
+ private static void validateWindowAggCallsSupported(Window.Group
windowGroup) {
+ for (Window.RexWinAggCall aggCall : windowGroup.aggCalls) {
+ SqlKind aggKind = aggCall.getKind();
+
Preconditions.checkState(SUPPORTED_WINDOW_FUNCTION_KIND.contains(aggKind),
+ String.format("Unsupported Window function kind: %s. Only
aggregation functions are supported!", aggKind));
+ }
+ }
+
+ private static void validateWindowFrames(Window.Group windowGroup) {
+ RexWindowBound lowerBound = windowGroup.lowerBound;
+ RexWindowBound upperBound = windowGroup.upperBound;
+
+ boolean hasOffset = (lowerBound.isPreceding() &&
!lowerBound.isUnbounded()) || (upperBound.isFollowing()
+ && !upperBound.isUnbounded());
+
+ if (!windowGroup.isRows) {
+ Preconditions.checkState(!hasOffset, "RANGE window frame with offset
PRECEDING / FOLLOWING is not supported");
Review Comment:
my bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
