Copilot commented on code in PR #16076:
URL: https://github.com/apache/pinot/pull/16076#discussion_r2140098486
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -644,21 +666,21 @@ public static QueryResult runReducer(long requestId,
Map.Entry<QueryErrorCode, String> error;
String from;
if (errorBlock.getStageId() >= 0) {
- from = "from stage " + errorBlock.getStageId();
+ from = " from stage " + errorBlock.getStageId();
if (errorBlock.getServerId() != null) {
- from += " on server " + errorBlock.getServerId();
+ from += " on " + errorBlock.getServerId();
}
} else {
- from = "from servers";
+ from = "";
Review Comment:
Replacing the default error origin 'from servers' with an empty string may
reduce the clarity of error logs when no server ID is provided. Consider
retaining a fallback message that provides useful context for diagnosing broker
failures.
```suggestion
from = " from an unknown source";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
