Jackie-Jiang commented on code in PR #16035:
URL: https://github.com/apache/pinot/pull/16035#discussion_r2133111812


##########
pinot-query-planner/src/test/resources/queries/ExplainPhysicalPlans.json:
##########
@@ -140,56 +140,14 @@
         "description": "explain plan with semi-join + group-by with colocated 
tables",
         "sql": "EXPLAIN IMPLEMENTATION PLAN FOR SELECT a.col1, COUNT(*) FROM a 
/*+ tableOptions(partition_function='hashcode', partition_key='col2', 
partition_size='4') */  WHERE a.col2 IN (   SELECT b.col1    FROM b /*+ 
tableOptions(partition_function='hashcode', partition_key='col1', 
partition_size='4') */    WHERE b.col1 = 'z' )  GROUP BY a.col1",
         "output": [
-          "[0]@localhost:3|[0] MAIL_RECEIVE(BROADCAST_DISTRIBUTED)\n",
-          "├── [1]@localhost:1|[1] 
MAIL_SEND(BROADCAST_DISTRIBUTED)->{[0]@localhost:3|[0]} (Subtree Omitted)\n",
-          "└── [1]@localhost:2|[0] 
MAIL_SEND(BROADCAST_DISTRIBUTED)->{[0]@localhost:3|[0]}\n",
-          "    └── [1]@localhost:2|[0] AGGREGATE_FINAL\n",
-          "        └── [1]@localhost:2|[0] MAIL_RECEIVE(HASH_DISTRIBUTED)\n",
-          "            ├── [2]@localhost:2|[2] 
MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost:1|[1],[1]@localhost:2|[0]} (Subtree 
Omitted)\n",
-          "            ├── [2]@localhost:2|[3] 
MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost:1|[1],[1]@localhost:2|[0]} (Subtree 
Omitted)\n",
-          "            ├── [2]@localhost:1|[0] 
MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost:1|[1],[1]@localhost:2|[0]} (Subtree 
Omitted)\n",
-          "            └── [2]@localhost:1|[1] 
MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost:1|[1],[1]@localhost:2|[0]}\n",
-          "                └── [2]@localhost:1|[1] AGGREGATE_LEAF\n",
-          "                    └── [2]@localhost:1|[1] JOIN\n",
-          "                        ├── [2]@localhost:1|[1] PROJECT\n",
-          "                        │   └── [2]@localhost:1|[1] TABLE SCAN (a) 
null\n",
-          "                        └── [2]@localhost:1|[1] 
MAIL_RECEIVE(BROADCAST_DISTRIBUTED)\n",
-          "                            ├── [3]@localhost:2|[2] 
MAIL_SEND(BROADCAST_DISTRIBUTED)->{[2]@localhost:1|[0, 1],[2]@localhost:2|[2, 
3]} (Subtree Omitted)\n",
-          "                            ├── [3]@localhost:2|[3] 
MAIL_SEND(BROADCAST_DISTRIBUTED)->{[2]@localhost:1|[0, 1],[2]@localhost:2|[2, 
3]} (Subtree Omitted)\n",
-          "                            ├── [3]@localhost:1|[0] 
MAIL_SEND(BROADCAST_DISTRIBUTED)->{[2]@localhost:1|[0, 1],[2]@localhost:2|[2, 
3]} (Subtree Omitted)\n",
-          "                            └── [3]@localhost:1|[1] 
MAIL_SEND(BROADCAST_DISTRIBUTED)->{[2]@localhost:1|[0, 1],[2]@localhost:2|[2, 
3]}\n",
-          "                                └── [3]@localhost:1|[1] PROJECT\n",
-          "                                    └── [3]@localhost:1|[1] 
FILTER\n",
-          "                                        └── [3]@localhost:1|[1] 
TABLE SCAN (b) null\n",
-          ""
+          "[0]@localhost:3|[0] MAIL_RECEIVE(BROADCAST_DISTRIBUTED)\n├── 
[1]@localhost:1|[1] MAIL_SEND(BROADCAST_DISTRIBUTED)->{[0]@localhost:3|[0]} 
(Subtree Omitted)\n└── [1]@localhost:2|[0] 
MAIL_SEND(BROADCAST_DISTRIBUTED)->{[0]@localhost:3|[0]}\n    └── 
[1]@localhost:2|[0] AGGREGATE_FINAL\n        └── [1]@localhost:2|[0] 
MAIL_RECEIVE(HASH_DISTRIBUTED)\n            ├── [2]@localhost:2|[2] 
MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost:1|[1],[1]@localhost:2|[0]} (Subtree 
Omitted)\n            ├── [2]@localhost:2|[3] 
MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost:1|[1],[1]@localhost:2|[0]} (Subtree 
Omitted)\n            ├── [2]@localhost:1|[0] 
MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost:1|[1],[1]@localhost:2|[0]} (Subtree 
Omitted)\n            └── [2]@localhost:1|[1] 
MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost:1|[1],[1]@localhost:2|[0]}\n        
        └── [2]@localhost:1|[1] AGGREGATE_LEAF\n                    └── 
[2]@localhost:
 1|[1] JOIN\n                        ├── [2]@localhost:1|[1] PROJECT\n          
              │   └── [2]@localhost:1|[1] FILTER\n                        │     
  └── [2]@localhost:1|[1] TABLE SCAN (a) null\n                        └── 
[2]@localhost:1|[1] MAIL_RECEIVE(BROADCAST_DISTRIBUTED)\n                       
     ├── [3]@localhost:2|[2] 
MAIL_SEND(BROADCAST_DISTRIBUTED)->{[2]@localhost:1|[0, 1],[2]@localhost:2|[2, 
3]} (Subtree Omitted)\n                            ├── [3]@localhost:2|[3] 
MAIL_SEND(BROADCAST_DISTRIBUTED)->{[2]@localhost:1|[0, 1],[2]@localhost:2|[2, 
3]} (Subtree Omitted)\n                            ├── [3]@localhost:1|[0] 
MAIL_SEND(BROADCAST_DISTRIBUTED)->{[2]@localhost:1|[0, 1],[2]@localhost:2|[2, 
3]} (Subtree Omitted)\n                            └── [3]@localhost:1|[1] 
MAIL_SEND(BROADCAST_DISTRIBUTED)->{[2]@localhost:1|[0, 1],[2]@localhost:2|[2, 
3]}\n                                └── [3]@localhost:1|[1
 ] PROJECT\n                                    └── [3]@localhost:1|[1] 
FILTER\n                                        └── [3]@localhost:1|[1] TABLE 
SCAN (b) null\n"

Review Comment:
   Break it into multiple lines for readability. Same for other changes in test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to