Jackie-Jiang commented on code in PR #16025:
URL: https://github.com/apache/pinot/pull/16025#discussion_r2132648505
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/nullvalue/NullValueIndexType.java:
##########
@@ -79,19 +79,18 @@ public String getPrettyName() {
}
@Override
- public ColumnConfigDeserializer<IndexConfig> createDeserializer() {
+ public ColumnConfigDeserializer<IndexConfig>
createDeserializerNotFromIndexes() {
return (TableConfig tableConfig, Schema schema) -> {
Collection<FieldSpec> allFieldSpecs = schema.getAllFieldSpecs();
Map<String, IndexConfig> configMap =
Maps.newHashMapWithExpectedSize(allFieldSpecs.size());
- boolean enableColumnBasedNullHandling =
schema.isEnableColumnBasedNullHandling();
- boolean nullHandlingEnabled = tableConfig.getIndexingConfig() != null
- && tableConfig.getIndexingConfig().isNullHandlingEnabled();
+ boolean columnBasedNullHandlingEnabled =
schema.isEnableColumnBasedNullHandling();
+ boolean nullHandlingEnabled =
tableConfig.getIndexingConfig().isNullHandlingEnabled();
Review Comment:
Yes. `IndexingConfig` is guaranteed to be non-null in the constructor of
`TableConfig` and setter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
