UOETianleZhang commented on code in PR #15954: URL: https://github.com/apache/pinot/pull/15954#discussion_r2132488291
########## pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java: ########## @@ -53,6 +51,8 @@ import org.apache.pinot.core.query.request.context.QueryContext; import org.apache.pinot.core.query.request.context.utils.QueryContextConverterUtils; import org.apache.pinot.segment.local.utils.SchemaUtils; +import org.apache.pinot.spi.auth.request.BrokerRequest; Review Comment: Let's put `BrokerRequest` to `org.apache.pinot.spi.request.BrokerRequest` as it is not necessarily related to auth ########## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TimeSeriesBucketTransformFunction.java: ########## @@ -25,13 +25,13 @@ import java.util.Map; import java.util.concurrent.TimeUnit; import org.apache.pinot.common.function.TransformFunctionType; -import org.apache.pinot.common.request.Literal; import org.apache.pinot.common.request.context.ExpressionContext; import org.apache.pinot.common.request.context.FunctionContext; import org.apache.pinot.common.request.context.RequestContextUtils; import org.apache.pinot.core.operator.ColumnContext; import org.apache.pinot.core.operator.blocks.ValueBlock; import org.apache.pinot.core.operator.transform.TransformResultMetadata; +import org.apache.pinot.spi.auth.request.Literal; Review Comment: Same here. For all the thrift-generated classes we can put them into `org.apache.pinot.spi.request` ########## pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java: ########## @@ -53,6 +51,8 @@ import org.apache.pinot.core.query.request.context.QueryContext; import org.apache.pinot.core.query.request.context.utils.QueryContextConverterUtils; import org.apache.pinot.segment.local.utils.SchemaUtils; +import org.apache.pinot.spi.auth.request.BrokerRequest; +import org.apache.pinot.spi.auth.request.PinotQuery; Review Comment: Same, we can put it into `org.apache.pinot.spi.request` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
