ankitsultana opened a new pull request, #16023:
URL: https://github.com/apache/pinot/pull/16023

   # Summary
   
   In #15760 we had added support for inferring invalid segment partition id. 
That didn't work completely for us because we one of our colocated join 
use-cases also leverages upsert compaction, and we are seeing a behavior where 
after compaction and segment only has invalid segment partition records, which 
changes that segment's partition. Since segment assignment is not done again as 
part of compaction, this leads to segments for a given partition to span 
multiple servers.
   
   In this PR I have marked the old query option as Deprecated and added a new 
one which is broader and is capable of handling this edge case too.
   
   # Test Plan
   
   Added quite a bit of unit-tests. We also have existing unit-tests which do 
sanity testing. Testing this particular scenario E2E is hard but we are 
planning to deploy this patch to our cluster within a few days itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to