tarun11Mavani commented on PR #16006: URL: https://github.com/apache/pinot/pull/16006#issuecomment-2945155684
> @tarun11Mavani : general comment: if we cache zk segment creation time, then we need to make sure that when a segment is updated, if its creation time changes, then we need to handle it accurately (as in the cache is updated at the right time). How are we making sure of that? I am calling `cacheSegmentCreationTimeFromZK` that updated the cache before any segment update related flow like doAddSegment, doReplaceSegment etc. I feel updating the time before working on the segment is the approach but I am open for feedback. Do let me know if there is a better way to update cache value. As I mentioned in the RFC doc, the creation time is not touched often. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
