ankitsultana commented on PR #15999: URL: https://github.com/apache/pinot/pull/15999#issuecomment-2945100075
> The purpose of these knobs are for users to turn off rules that are taking too long / produces suboptimal plan. All rules are enabled by default. I suppose these knobs are not just for debugging. It is expected that users may use this in their production workloads. Correct? > The naming convention here is consistent with the rule name shown on query console from EXPLAIN PLAN FOR, it's just plannerRule.skip<name as shown on console>. I think this makes sense to some extent for rules in Calcite. But for rules implemented by us, we should instead use shorter names. We could create a new abstract class that overrides `RelOptRule` and adds an abstract method to define a name to be used for this purpose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
