Copilot commented on code in PR #16010:
URL: https://github.com/apache/pinot/pull/16010#discussion_r2128899236
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -124,7 +124,12 @@ private void sendInternal(MseBlock block, List<DataBuffer>
serializedStats)
if (_contentObserver == null) {
_contentObserver = getContentObserver();
}
- splitAndSend(block, serializedStats);
+ try {
+ splitAndSend(block, serializedStats);
+ } catch (IOException e) {
+ LOGGER.warn("Failed to split and send mailbox", e);
Review Comment:
[nitpick] Consider including additional context (e.g., mailbox ID or block
details) in the warning log to ease debugging.
```suggestion
LOGGER.warn("Failed to split and send mailbox. Mailbox ID: {}, Block:
{}", _id, block, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
