UOETianleZhang commented on code in PR #15982:
URL: https://github.com/apache/pinot/pull/15982#discussion_r2125141175
##########
.github/workflows/pinot_tests.yml:
##########
@@ -98,8 +101,34 @@ jobs:
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-
- - name: Verify with binary-compatibility-check profile
- run: mvn verify -DskipTests -Pbinary-compat-check -T1C
+ - name: Build SPI on PR branch
+ run: mvn clean package -T1C -pl ${{ matrix.module }} -am -DskipTests
-Dproject.build.finalName="${{ matrix.module }}"
+ - name: Checkout master into a subfolder
+ uses: actions/checkout@v4
+ with:
+ ref: master
+ path: master-head
+ - name: Build SPI on master
+ working-directory: master-head
+ run: mvn clean package -T1C -pl ${{ matrix.module }} -am -DskipTests
-Dproject.build.finalName="${{ matrix.module }}"
+ - name: Download japicmp CLI
+ run: |
+ JAPICMP_VER=0.23.1
+ curl -fSL \
+ -o japicmp.jar \
+
"https://repo1.maven.org/maven2/com/github/siom79/japicmp/japicmp/${JAPICMP_VER}/japicmp-${JAPICMP_VER}-jar-with-dependencies.jar";
+
Review Comment:
Can we also add some comments here to explain our intention?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
