gortiz commented on PR #15895: URL: https://github.com/apache/pinot/pull/15895#issuecomment-2934712451
If this is a single unsafe/safe crossover, then let us introduce a config that users can roll once they are in safe version. We can even provide a controller API if needed to assure that they are indeed in safe version. The users can then do a one-time restart with the new config. The idea is precisely to avoid that. We have tons of different configs for different features that were designed based on that pattern, where the operators need to be aware of the release notes, then they need to be sure the config has a specific value and finally set the config back to the final value after the release is complete. And sometimes the operators need to restart the cluster after that to apply the new config. This process doesn't scale. Pinot is progressing much faster now, and asking humans to be aware of all these config changes is error-prone. Instead, we can detect whether an instance is on a heterogeneous cluster or not. This should be a cheap operation. Perhaps the current implementation is not the most effective. I'm not an expert on Helix, and there may be cheaper ways to receive a notification when a new instance joins the cluster. But the theoretical concept of what we are trying to implement seems pretty simple and it must be a way to get notified without investing too many resources. I'm open to new ideas or implementations, but I don't think we should resign to the old manual and error-prone way to upgrade our system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
