tarun11Mavani commented on PR #15938: URL: https://github.com/apache/pinot/pull/15938#issuecomment-2922893294
> Oh we are using creation_meta? > > Hmm, why aren't we using the Segment ZK Metadata? That should be a much better approach isn't it? We need to use creation_meta as tie breaker in [shouldReplaceOnComparisonTie](https://github.com/apache/pinot/blob/d6732ffd1943a6a11358ad36645e07769e1c84ff/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java#L515) uses the creation.meta from the server to decide to keep or replace the record. So if we use creation.meta from ZK while generating the task and use that the creation time for new merge segment, we will still run into inconsistency issue as two servers can have different creation.meta value which is stored in the segment dir on each server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
