deepthi912 commented on code in PR #15933:
URL: https://github.com/apache/pinot/pull/15933#discussion_r2112938622
##########
pinot-common/src/main/java/org/apache/pinot/common/tier/TierSegmentSelector.java:
##########
@@ -18,21 +18,17 @@
*/
package org.apache.pinot.common.tier;
+import org.apache.pinot.common.metadata.segment.SegmentZKMetadata;
+
+
/**
* Interface for the segment selection strategy of a tier
*/
public interface TierSegmentSelector {
- /**
- * The type of the segment selector (e.g. TIME)
- */
+ /// Returns the type of the segment selector (e.g. TIME).
String getType();
- /**
- * Checks if the provided segment is eligible for selection to this tier
- * @param tableNameWithType Name of the table
- * @param segmentName Name of the segment
- * @return true if eligible
- */
- boolean selectSegment(String tableNameWithType, String segmentName);
+ /// Returns `true` if the segment is eligible for the tier.
+ boolean selectSegment(String tableNameWithType, SegmentZKMetadata
segmentZKMetadata);
Review Comment:
There might be cases where segmentZKMetadata is not available for a segment
yet for example when new segments are created on minion task, and we want make
use of `boolean selectSegment(String tableNameWithType, String segmentName)` to
identify if a segment belongs to a tier, How would we handle such case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
