dinoocch commented on code in PR #15828:
URL: https://github.com/apache/pinot/pull/15828#discussion_r2110686309
##########
pinot-broker/src/main/java/org/apache/pinot/broker/querylog/QueryLogger.java:
##########
@@ -308,6 +308,22 @@ void doFormat(StringBuilder builder, QueryLogger logger,
QueryLogParams params)
void doFormat(StringBuilder builder, QueryLogger logger, QueryLogParams
params) {
builder.append(params._queryEngine.getName());
}
+ },
+
OFFLINE_THREAD_MEM_ALLOCATED_BYTES("offlineThreadMemAllocatedBytes(total/thread/resSer)",
':') {
+ @Override
+ void doFormat(StringBuilder builder, QueryLogger logger, QueryLogParams
params) {
+
builder.append(params._response.getOfflineTotalMemAllocatedBytes()).append('/')
+
.append(params._response.getOfflineThreadMemAllocatedBytes()).append('/')
+
.append(params._response.getOfflineResponseSerMemAllocatedBytes()).append('/');
Review Comment:
Do you want these trailing slashes?
##########
pinot-broker/src/main/java/org/apache/pinot/broker/querylog/QueryLogger.java:
##########
@@ -308,6 +308,22 @@ void doFormat(StringBuilder builder, QueryLogger logger,
QueryLogParams params)
void doFormat(StringBuilder builder, QueryLogger logger, QueryLogParams
params) {
builder.append(params._queryEngine.getName());
}
+ },
+
OFFLINE_THREAD_MEM_ALLOCATED_BYTES("offlineThreadMemAllocatedBytes(total/thread/resSer)",
':') {
Review Comment:
Maybe a nit but do we mean "offlineMemAllocatedBytes"? Shorter naming will
be better for our log volume since this is per query
##########
pinot-core/src/main/java/org/apache/pinot/core/query/logger/ServerQueryLogger.java:
##########
@@ -151,6 +151,25 @@ public void logQuery(ServerQueryRequest request,
InstanceResponseBlock response,
TimeUnit.NANOSECONDS);
}
+ long threadMemAllocatedBytes = getLongValue(responseMetadata,
MetadataKey.THREAD_MEM_ALLOCATED_BYTES.getName(), 0);
+ if (threadMemAllocatedBytes > 0) {
Review Comment:
Why have this check vs just always adding the gauge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
