vrajat commented on code in PR #15900:
URL: https://github.com/apache/pinot/pull/15900#discussion_r2111177617


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -422,6 +423,19 @@ public SuccessResponse deleteTable(
     List<String> tablesDeleted = new LinkedList<>();
     try {
       tableName = DatabaseUtils.translateTableName(tableName, headers);
+      // Validate the table is not referenced in any logical table config.

Review Comment:
   Is `tableName` a raw or phyiscal table name or can be any one of them ? IIUC 
`tableName` will be the raw table name. Should the check be on the physical 
table names instead and NOT on the raw table name since table type has been 
specified ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to