somandal commented on code in PR #15817:
URL: https://github.com/apache/pinot/pull/15817#discussion_r2110394455
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/SegmentAssignmentUtils.java:
##########
@@ -448,10 +472,10 @@ public static int getOfflineSegmentPartitionId(String
segmentName, String offlin
ZKMetadataProvider.getSegmentZKMetadata(helixManager.getHelixPropertyStore(),
offlineTableName, segmentName);
Preconditions.checkState(segmentZKMetadata != null,
"Failed to find segment ZK metadata for segment: %s of table: %s",
segmentName, offlineTableName);
- return getPartitionId(segmentZKMetadata, offlineTableName,
partitionColumn);
+ return getOfflinePartitionId(segmentZKMetadata, offlineTableName,
partitionColumn);
}
- private static int getPartitionId(SegmentZKMetadata segmentZKMetadata,
String offlineTableName,
+ private static int getOfflinePartitionId(SegmentZKMetadata
segmentZKMetadata, String offlineTableName,
@Nullable String partitionColumn) {
Review Comment:
i've updated the function called to handle partitionColumn = null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
