UOETianleZhang commented on PR #15879: URL: https://github.com/apache/pinot/pull/15879#issuecomment-2905731987
> The main concern upgrading the baseline jar is... why do we need to do that? If Japicmp has detected an actual incompatibility we should discuss whether we want to introduce it or not (in which case the baseline should be upgraded in the same PR we break compatibility). If the issue is that Japicmp is failing on a false positive then it may not be mature enough to be added into the normal CI +1 on this. Looks like https://github.com/apache/pinot/pull/15526 introduced some back-incompatible SPI changes and somehow it was able to be merged even if it failed the check. Can we revert this change https://github.com/apache/pinot/pull/15526 and discuss the necessity of the incompatibility, instead of reverting https://github.com/apache/pinot/pull/15737? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
